Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 155326: Making it possible to run scons on vista using VS2008 without having to insta... (Closed)

Created:
11 years, 5 months ago by vangelis
Modified:
9 years, 7 months ago
CC:
o3d-review_googlegroups.com
Visibility:
Public.

Description

Making it possible to run scons on vista using VS2008 without having to install an additional MS SDK. VS2008 does come with SDK version 6.0, it's just that the registry entries for it are slightly different than in XP. This change takes care of Vista but I'm not sure what the registry looks like in Windows XP when you install VS 2008. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20356

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M build/build_nacl.py View 1 chunk +7 lines, -2 lines 0 comments Download
M svn_paths.scons View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
vangelis
11 years, 5 months ago (2009-07-09 22:03:04 UTC) #1
Ken Russell (Google)
11 years, 5 months ago (2009-07-09 23:35:03 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698