Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: webkit/glue/webcursor_mac.mm

Issue 155320: Fix custom cursors on Mac. Null and 0 turn out not to be opposites.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/api/src/WebImageCG.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webcursor_mac.mm
===================================================================
--- webkit/glue/webcursor_mac.mm (revision 20280)
+++ webkit/glue/webcursor_mac.mm (working copy)
@@ -49,6 +49,8 @@
NSCursor* CreateCustomCursor(const std::vector<char>& custom_data,
const gfx::Size& custom_size,
const gfx::Point& hotspot) {
+ DCHECK(!custom_data.empty());
pink (ping after 24hrs) 2009/07/09 21:30:31 is it worth being over-protective (since this take
darin (slow to review) 2009/07/09 21:35:45 we should only reach here if webkit tries to send
+
scoped_cftyperef<CGImageRef> cg_image(
CreateCGImageFromCustomData(custom_data, custom_size));
« no previous file with comments | « webkit/api/src/WebImageCG.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698