Issue 155310: GTK Themes: Prevent colors from "leaking through" by using an event box.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155310: GTK Themes: Prevent colors from "leaking through" by using an event box. (Closed)

Created:
11 years, 5 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
tony, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

GTK Themes: Prevent colors from "leaking through" by using an event box. Some engines (clearlooks) query the bg color of a widget directly, so wrap the toolbar in an event box so that the bg value set in browser_window_gtk.cc doesn't leak through. http://crbug.com/13967 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20308

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
	M	chrome/browser/gtk/browser_toolbar_gtk.h	View		2 chunks	+7 lines, -1 line	0 comments	Download
	M	chrome/browser/gtk/browser_toolbar_gtk.cc	View		3 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages