Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1389)

Unified Diff: src/scripts/build_image

Issue 1553028: Fix install mask and move dev_mode to true when dev packages are installed (Closed)
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/scripts/common.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/scripts/build_image
diff --git a/src/scripts/build_image b/src/scripts/build_image
index 722a8ef62b9ca0f604bb8b62f403e47984917011..58d6ba87c764c590ef5462e8d5eed87d43692689 100755
--- a/src/scripts/build_image
+++ b/src/scripts/build_image
@@ -277,7 +277,7 @@ sudo cp -a "${BOARD_ROOT}"/lib/libgcc_s.so* "${ROOT_FS_DIR}/lib"
sudo cp -a "${BOARD_ROOT}"/usr/lib/libstdc++.so* "${ROOT_FS_DIR}/usr/lib"
INSTALL_MASK=""
-if [[ $FLAGS_installmask -eq $FLAGS_FALSE ]] ; then
+if [[ $FLAGS_installmask -eq ${FLAGS_TRUE} ]] ; then
INSTALL_MASK="$DEFAULT_INSTALL_MASK"
fi
@@ -319,6 +319,11 @@ if [[ $FLAGS_withdev -eq $FLAGS_TRUE ]] ; then
--root="$ROOT_DEV_DIR" --root-deps=rdeps \
--usepkgonly chromeos-dev $EMERGE_JOBS
+ # TODO(sosa@chromium.org) - Re-hide under statefuldev after switch
+ # Flag will mount /usr/local on target device
+ sudo mkdir -p "$ROOT_FS_DIR/root"
+ sudo touch "$ROOT_FS_DIR/root/.dev_mode"
+
# The ldd tool is a useful shell script but lives in glibc; just copy it.
sudo cp -a "$(which ldd)" "${ROOT_DEV_DIR}/usr/bin"
fi
@@ -387,13 +392,8 @@ menuentry "normal" {
EOF
-# Enable dev mode on the target system and re-run ldconfig
-# for rootfs's ld.so.cache
+# Run ldconfig for rootfs's ld.so.cache
if [ $FLAGS_statefuldev -eq $FLAGS_TRUE ] ; then
- # Flag will mount /usr/local on target device
- sudo mkdir -p "$ROOT_FS_DIR/root"
- sudo touch "$ROOT_FS_DIR/root/.dev_mode"
-
# Re-run ldconfig to fix /etc/ldconfig.so.cache
sudo /sbin/ldconfig -r "$ROOT_FS_DIR"
« no previous file with comments | « no previous file | src/scripts/common.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698