Issue 1553028: Fix install mask and move dev_mode to true when dev packages are installed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1553028: Fix install mask and move dev_mode to true when dev packages are installed (Closed)

Created:
10 years, 8 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
Chris Masone, adlr

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Fix install mask and move dev_mode to true when dev packages are installed

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	src/scripts/build_image	View		3 chunks	+7 lines, -7 lines	0 comments	Download
	M	src/scripts/common.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sosa

Until we've moved to statefuldev, touch dev_mode in build_image and fix installmask which was set ...

10 years, 8 months ago (2010-04-13 16:55:14 UTC) #1

sosa

Change so that --statefuldev isn't needed so that var persists.

10 years, 8 months ago (2010-04-13 21:50:48 UTC) #2

sosa

10 years, 8 months ago (2010-04-13 23:03:15 UTC) #4

no problem-o.  thanks!

On Tue, Apr 13, 2010 at 2:53 PM,  <adlr@chromium.org> wrote:
> LGTM sorry for the delay
>
> http://codereview.chromium.org/1553028/show
>

Expand Messages | Collapse Messages