Run hwqual on test_mod=true as it has dependencies on test_mod=true.

Run hwqual on test_mod=true as it has dependencies on test_mod=true.

[kmixter1, 2010-04-12 19:03:18]

This will cause all (non-official as well) builds to do archive_hwqual
release packaging.  Is that desirable?  Shouldn't all official builds
also pass --test_mod?  If so, the best thing to do might be to throw
an error if an official build is used without test_mod.

On Mon, Apr 12, 2010 at 11:48 AM,  <djmm@chromium.org> wrote:
> Reviewers: kmixter, petkov,
>
> Description:
> Run hwqual on test_mod=true as it has dependencies on test_mod=true.
>
> Please review this at http://codereview.chromium.org/1553025/show
>
> Affected files:
>  M src/scripts/archive_build.sh
>
>
> Index: src/scripts/archive_build.sh
> diff --git a/src/scripts/archive_build.sh b/src/scripts/archive_build.sh
> index
>
127638d71463e59951414b4b5e065d6b20a2cc69..1040d2dbdf18abceafd1284c01f9d84570d68526
> 100755
> --- a/src/scripts/archive_build.sh
> +++ b/src/scripts/archive_build.sh
> @@ -116,7 +116,7 @@ echo "$LAST_CHANGE" > "${FLAGS_to}/LATEST"
>  chmod 644 "$ZIPFILE" "${FLAGS_to}/LATEST"
>  chmod 755 "$OUTDIR"
>
> -if [ $FLAGS_official_build -eq $FLAGS_TRUE ]
> +if [ $FLAGS_test_mod -eq $FLAGS_TRUE ]
>  then
>   echo "Creating hwqual archive"
>   HWQUAL_NAME="chromeos-hwqual-${FLAGS_board}-${CHROMEOS_VERSION_STRING}"
>
>
>

[djmm, 2010-04-12 19:04:09]

My motivation here is to allow anyone to build an official build without all
the extras using an internal script I'm working on in parallel.  Perhaps the
right thing to do is condition on both here.  I'll make the change.

On Mon, Apr 12, 2010 at 11:59 AM, Ken Mixter <kmixter@google.com> wrote:

> This will cause all (non-official as well) builds to do archive_hwqual
> release packaging.  Is that desirable?  Shouldn't all official builds
> also pass --test_mod?  If so, the best thing to do might be to throw
> an error if an official build is used without test_mod.
>
> On Mon, Apr 12, 2010 at 11:48 AM,  <djmm@chromium.org> wrote:
> > Reviewers: kmixter, petkov,
> >
> > Description:
> > Run hwqual on test_mod=true as it has dependencies on test_mod=true.
> >
> > Please review this at http://codereview.chromium.org/1553025/show
> >
> > Affected files:
> >  M src/scripts/archive_build.sh
> >
> >
> > Index: src/scripts/archive_build.sh
> > diff --git a/src/scripts/archive_build.sh b/src/scripts/archive_build.sh
> > index
> >
>
127638d71463e59951414b4b5e065d6b20a2cc69..1040d2dbdf18abceafd1284c01f9d84570d68526
> > 100755
> > --- a/src/scripts/archive_build.sh
> > +++ b/src/scripts/archive_build.sh
> > @@ -116,7 +116,7 @@ echo "$LAST_CHANGE" > "${FLAGS_to}/LATEST"
> >  chmod 644 "$ZIPFILE" "${FLAGS_to}/LATEST"
> >  chmod 755 "$OUTDIR"
> >
> > -if [ $FLAGS_official_build -eq $FLAGS_TRUE ]
> > +if [ $FLAGS_test_mod -eq $FLAGS_TRUE ]
> >  then
> >   echo "Creating hwqual archive"
> >   HWQUAL_NAME="chromeos-hwqual-${FLAGS_board}-${CHROMEOS_VERSION_STRING}"
> >
> >
> >
>

[djmm, 2010-04-12 19:10:04]

PTAL

On Mon, Apr 12, 2010 at 12:03 PM, David McMahon <djmm@chromium.org> wrote:

>
> My motivation here is to allow anyone to build an official build without
> all the extras using an internal script I'm working on in parallel.  Perhaps
> the right thing to do is condition on both here.  I'll make the change.
>
>
> On Mon, Apr 12, 2010 at 11:59 AM, Ken Mixter <kmixter@google.com> wrote:
>
>> This will cause all (non-official as well) builds to do archive_hwqual
>> release packaging.  Is that desirable?  Shouldn't all official builds
>> also pass --test_mod?  If so, the best thing to do might be to throw
>> an error if an official build is used without test_mod.
>>
>> On Mon, Apr 12, 2010 at 11:48 AM,  <djmm@chromium.org> wrote:
>> > Reviewers: kmixter, petkov,
>> >
>> > Description:
>> > Run hwqual on test_mod=true as it has dependencies on test_mod=true.
>> >
>> > Please review this at http://codereview.chromium.org/1553025/show
>> >
>> > Affected files:
>> >  M src/scripts/archive_build.sh
>> >
>> >
>> > Index: src/scripts/archive_build.sh
>> > diff --git a/src/scripts/archive_build.sh b/src/scripts/archive_build.sh
>> > index
>> >
>>
127638d71463e59951414b4b5e065d6b20a2cc69..1040d2dbdf18abceafd1284c01f9d84570d68526
>> > 100755
>> > --- a/src/scripts/archive_build.sh
>> > +++ b/src/scripts/archive_build.sh
>> > @@ -116,7 +116,7 @@ echo "$LAST_CHANGE" > "${FLAGS_to}/LATEST"
>> >  chmod 644 "$ZIPFILE" "${FLAGS_to}/LATEST"
>> >  chmod 755 "$OUTDIR"
>> >
>> > -if [ $FLAGS_official_build -eq $FLAGS_TRUE ]
>> > +if [ $FLAGS_test_mod -eq $FLAGS_TRUE ]
>> >  then
>> >   echo "Creating hwqual archive"
>> >
>> HWQUAL_NAME="chromeos-hwqual-${FLAGS_board}-${CHROMEOS_VERSION_STRING}"
>> >
>> >
>> >
>>
>
>

[kmixter1, 2010-04-12 19:18:49]

LGTM