Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: scripts/vbug205541.patch

Issue 1553024: Update Memcheck to rev 11055 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/valgrind/
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « scripts/common.sh ('k') | scripts/vbug227570.patch » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 # See https://bugs.kde.org/show_bug.cgi?id=205541#c1
2 Index: memcheck/mc_main.c
3 ===================================================================
4 --- memcheck/mc_main.c (revision 10877)
5 +++ memcheck/mc_main.c (working copy)
6 @@ -3708,7 +3708,14 @@
7 if (rr || ww || xx)
8 MC_(make_mem_defined)(a, len);
9 else
10 - MC_(make_mem_noaccess)(a, len);
11 + MC_(make_mem_defined)(a, len);
12 + /* State after mmap(,,PROT_NONE,,,) should match
13 + * state after mprotect(,,PROT_NONE): the operating system
14 + * will trap any access, but any subsequent mprotect(,,PROT_R|W|X)
15 + * will re-instate the previous V bits [in this case, all valid].
16 + * See comment in mc_pre_clo_init() re:
17 + * VG_(track_change_mem_mprotect) ( NULL );
18 + */
19 }
20
21 static
OLDNEW
« no previous file with comments | « scripts/common.sh ('k') | scripts/vbug227570.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698