Issue 155286: X64: Let debugger patch JSReturn with a debug break.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155286: X64: Let debugger patch JSReturn with a debug break. (Closed)

Created:
11 years, 5 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64: Let debugger patch JSReturn with a debug break. Committed: http://code.google.com/p/v8/source/detail?r=2421

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -45 lines)			Patch
M	src/debug.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View	1	2 chunks	+67 lines, -39 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1	1 chunk	+9 lines, -4 lines	0 comments	Download
M	src/x64/debug-x64.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/155286/diff/1/5 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/155286/diff/1/5#newcode359 Line 359: for (int i = 0; i < ...

11 years, 5 months ago (2009-07-09 12:54:43 UTC) #2

William Hesse

11 years, 5 months ago (2009-07-09 13:29:46 UTC) #3

http://codereview.chromium.org/155286/diff/1/5
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/155286/diff/1/5#newcode359
Line 359: for (int i = 0; i < 6; ++i) {
On 2009/07/09 12:54:43, Lasse Reichstein wrote:
> What is the "6" magic constant? Can it be computed from the
> kX64JSReturnSequenceLength? (e.g., minus length of some opcode).

Done.

Expand Messages | Collapse Messages