Issue 155283: Allow access through the global proxy to use ICs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155283: Allow access through the global proxy to use ICs. (Closed)

Created:
11 years, 5 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Allow access through the global proxy to use ICs. Committed: http://code.google.com/p/v8/source/detail?r=2413

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+153 lines, -52 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	5 chunks	+33 lines, -13 lines	1 comment	Download
M	src/ia32/stub-cache-ia32.cc	View	5 chunks	+32 lines, -12 lines	0 comments	Download
M	src/ic.cc	View	2 chunks	+18 lines, -17 lines	0 comments	Download
M	src/stub-cache.h	View	4 chunks	+8 lines, -4 lines	0 comments	Download
M	src/stub-cache.cc	View	3 chunks	+10 lines, -4 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
A	test/mjsunit/global-ic.js	View	1 chunk	+48 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

11 years, 5 months ago (2009-07-09 11:15:04 UTC) #2

LGTM

http://codereview.chromium.org/155283/diff/1/7
File src/arm/stub-cache-arm.cc (right):

http://codereview.chromium.org/155283/diff/1/7#newcode1041
Line 1041: // Get the receiver from the stack.
Is receiver the right word here?

Expand Messages | Collapse Messages