Issue 155279: X64: Fix bug in left-shift.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155279: X64: Fix bug in left-shift. (Closed)

Created:
11 years, 5 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Visibility:
Public.

Description

X64: Fix bug in left-shift. Also changed a few other places that looked suspicious in the same way. Added more info to failing test case and rewrote incorrect uses of mjsunit "fail" function.

Patch Set 1 #

Total comments: 2

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+96 lines, -53 lines)			Patch
M	src/x64/assembler-x64.h	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	4 chunks	+6 lines, -8 lines	0 comments	Download
M	test/mjsunit/apply.js	View	8 chunks	+53 lines, -37 lines	2 comments	Download
M	test/mjsunit/array-reduce.js	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	test/mjsunit/big-array-literal.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/regress/regress-244.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

11 years, 5 months ago (2009-07-09 07:54:35 UTC) #2

LGTM.  Only formatting comments.

http://codereview.chromium.org/155279/diff/1/5
File test/mjsunit/apply.js (left):

http://codereview.chromium.org/155279/diff/1/5#oldcode59
Line 59: assertEquals("foo", f1.apply(this, new Array("foo", "bar", "baz",
"boo")), "2c");
Why not just shorten "bar", "baz" and "boo" by a character or two?

http://codereview.chromium.org/155279/diff/1/5
File test/mjsunit/apply.js (right):

http://codereview.chromium.org/155279/diff/1/5#newcode196
Line 196: "morseper",
I think you can put the first argument on the same line, but indent 2nd and
third argument only 4 spaces.

Expand Messages | Collapse Messages