Ensure proper paths when saving pages with no title

Ensure proper paths when saving pages with no title.

When saving a page with no title, such as a text file, attempt to
use a sane value for the save name by retrieving the last component
of the URL (if one exists).

This prevents the case where a page http://www.foo.com/a/path/name.txt
is saved as file "http www" with extension type "foo.com a path name.txt".

This change also makes the SavePackage code a little more flexible
and simpler to test.

BUG=none
TEST=Covered by unittest.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20432

[Paul Godavari, 2009-07-09 23:12:58]

No significant behavioral changes except for the first few lines of
SavePackage::GetSuggestedNameForSaveAs, where we now check to see if the name is
a URL. Please take a good look at the string conversions here.

[brettw, 2009-07-10 16:18:22]

http://codereview.chromium.org/155266/diff/15/1026
File chrome/browser/download/save_package_unittest.cc (right):

http://codereview.chromium.org/155266/diff/15/1026#newcode236
Line 236: {FPL("http://www.foo.com/path/title.txt"), FPL("title.txt"), false},
Can you add a testcase like "http://www.foo.com/path/"? What will happen then?

[Paul Godavari, 2009-07-10 19:50:51]

On 2009/07/10 16:18:22, brettw wrote:
> http://codereview.chromium.org/155266/diff/15/1026
> File chrome/browser/download/save_package_unittest.cc (right):
> 
> http://codereview.chromium.org/155266/diff/15/1026#newcode236
> Line 236: {FPL("http://www.foo.com/path/title.txt"), FPL("title.txt"), false},
> Can you add a testcase like "http://www.foo.com/path/"? What will happen then?

That depends. If "http://www.foo.com/path/" really points to an "index.html" (or
equivalent), when you save you'll be given a suggested save name of "http
www.foo.com path .html". If it's not html, it'll be "http www.foo.com path".

Looks like Firefox and Safari would attempt to save that URL as "path.html".

I can adjust the URL examining code to look for the last path component, or if
empty the domain name.

[brettw, 2009-07-10 20:50:19]

On Fri, Jul 10, 2009 at 12:50 PM, <paul@chromium.org> wrote:
> On 2009/07/10 16:18:22, brettw wrote:
>>
>> http://codereview.chromium.org/155266/diff/15/1026
>> File chrome/browser/download/save_package_unittest.cc (right):
>
>> http://codereview.chromium.org/155266/diff/15/1026#newcode236
>> Line 236: {FPL("http://www.foo.com/path/title.txt"), FPL("title.txt"),
>
> false},
>>
>> Can you add a testcase like "http://www.foo.com/path/"? What will
>
> happen then?
>
> That depends. If "http://www.foo.com/path/" really points to an
> "index.html" (or equivalent), when you save you'll be given a suggested
> save name of "http www.foo.com path .html". If it's not html, it'll be
> "http www.foo.com path".
>
> Looks like Firefox and Safari would attempt to save that URL as
> "path.html".
>
> I can adjust the URL examining code to look for the last path component,
> or if empty the domain name.

Sounds like a good idea.

Brett

[Paul Godavari, 2009-07-10 22:16:26]

Updated.

[brettw, 2009-07-10 22:19:39]

LGTM