Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 155264: Set the save file type index properly (Closed)

Created:
11 years, 5 months ago by Paul Godavari
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)
Visibility:
Public.

Description

Set the save file type index properly if there was only one file type. The save file indexes are 1 based, and if there is only one file type that the page can be saved as (such as a page like foo.com/notes.txt), the index is set to 0 which will cause a crash. BUG=15555 (http://crbug.com/15555) TEST=Go to a web page that is a text file and try to save it. Chrome should not crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20293

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/cocoa/shell_dialogs_mac.mm View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Godavari
11 years, 5 months ago (2009-07-09 02:06:14 UTC) #1
Avi (use Gerrit)
11 years, 5 months ago (2009-07-09 13:42:03 UTC) #2
LG

Powered by Google App Engine
This is Rietveld 408576698