Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 155242: Add temporary TabStripWrapper interface that is implemented by both TabStrip ... (Closed)

Created:
11 years, 5 months ago by Ben Goodger (Google)
Modified:
9 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Add temporary TabStripWrapper interface that is implemented by both TabStrip and BrowserTabStrip... this makes dealing with the multiple implementations more manageable in shared code like BrowserView, etc. This interface will die once the new work is completed and a conversion is finished. The interface contains all the methods that BrowserView expect to find on TabStrip. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20204

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -194 lines) Patch
M chrome/browser/views/frame/browser_frame.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/views/frame/browser_frame_win.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/views/frame/browser_frame_win.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/views/frame/browser_non_client_frame_view.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/frame/browser_root_view.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/views/frame/browser_root_view.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/views/frame/browser_view.h View 4 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/views/frame/browser_view.cc View 10 chunks +28 lines, -55 lines 0 comments Download
M chrome/browser/views/frame/glass_browser_frame_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/frame/glass_browser_frame_view.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/views/frame/opaque_browser_frame_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/frame/opaque_browser_frame_view.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/views/tabs/browser_tab_strip.h View 2 chunks +16 lines, -1 line 0 comments Download
M chrome/browser/views/tabs/browser_tab_strip.cc View 2 chunks +58 lines, -0 lines 0 comments Download
M chrome/browser/views/tabs/dragged_tab_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/views/tabs/tab_strip.h View 5 chunks +21 lines, -29 lines 0 comments Download
M chrome/browser/views/tabs/tab_strip.cc View 4 chunks +90 lines, -60 lines 0 comments Download
M chrome/browser/views/tabs/tab_strip_2.h View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/views/tabs/tab_strip_wrapper.h View 1 chunk +73 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
11 years, 5 months ago (2009-07-08 22:08:47 UTC) #1
sky
11 years, 5 months ago (2009-07-08 22:34:05 UTC) #2
OK

Powered by Google App Engine
This is Rietveld 408576698