chrome\common\child_process_logging_mac_unittest.mm - Issue 155238: Add the page url to plugin crashes to aid debugging.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome\common\child_process_logging_mac_unittest.mm

Issue 155238: Add the page url to plugin crashes to aid debugging. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/common/child_process_logging.h"	5 #include "chrome/common/child_process_logging.h"

6	6

7 #import <Foundation/Foundation.h>	7 #import <Foundation/Foundation.h>

8	8

9 #include "base/logging.h"	9 #include "base/logging.h"

10 #include "testing/gtest/include/gtest/gtest.h"	10 #include "testing/gtest/include/gtest/gtest.h"

(...skipping 118 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
129 EXPECT_EQ(mock.CountDictionaryEntries(), 0);	129 EXPECT_EQ(mock.CountDictionaryEntries(), 0);

130	130

131	131

132 // Check that overflow works correctly.	132 // Check that overflow works correctly.

133 SetActiveURLWithMock(GURL(overflow_url.c_str()));	133 SetActiveURLWithMock(GURL(overflow_url.c_str()));

134 EXPECT_TRUE(mock.VerifyDictionaryContents(	134 EXPECT_TRUE(mock.VerifyDictionaryContents(

135 overflow_url.substr(0, max_num_chars_stored_in_dump)));	135 overflow_url.substr(0, max_num_chars_stored_in_dump)));

136 SetActiveURLWithMock(GURL());	136 SetActiveURLWithMock(GURL());

137 EXPECT_EQ(mock.CountDictionaryEntries(), 0);	137 EXPECT_EQ(mock.CountDictionaryEntries(), 0);

138 }	138 }

OLD	NEW