Issue 155237: Added a media playback test to test_shell_tests...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155237: Added a media playback test to test_shell_tests... (Closed)

Created:
11 years, 5 months ago by Alpha Left Google

Modified:
9 years, 6 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Added a media playback test to test_shell_tests Added MediaLeakTest.BearH264 in test_shell_tests to play a media file in test_shell. This is to facilitate running purify to detect memory leaks in the media player and <video>. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20407

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -0 lines)			Patch
	A	webkit/tools/test_shell/media_leak_test.cc	View	1 2 3	1 chunk	+31 lines, -0 lines	0 comments	Download
	M	webkit/tools/test_shell/test_shell.gyp	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

LGTM with one nit check with darin or chromium-dev to see if this is an ...

11 years, 5 months ago (2009-07-08 20:47:06 UTC) #2

Alpha Left Google

11 years, 5 months ago (2009-07-08 20:49:00 UTC) #3

+darin

darin: I would like to run purify on <video> regularly for each build. I know
there's webkit layout purify bots but it is too slow to give feedback on memory
leaks in <video>. Do you think this change is a good way for this purpose?

Expand Messages | Collapse Messages