Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 155236: Revert change 20173 because it breaks the ui_tests, plugin_tests... (Closed)

Created:
11 years, 5 months ago by Nicolas Sylvain
Modified:
9 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews_googlegroups.com, John Grabowski, darin (slow to review), brettw
Visibility:
Public.

Description

Revert change 20173 because it breaks the ui_tests, plugin_tests and most likely some page cyclers. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20180

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -448 lines) Patch
M chrome/app/breakpad_win.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/chrome.gyp View 4 chunks +5 lines, -5 lines 0 comments Download
D chrome/common/child_process_logging.h View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/common/child_process_logging_linux.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/common/child_process_logging_mac.mm View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/common/child_process_logging_mac_unittest.mm View 1 chunk +0 lines, -138 lines 0 comments Download
D chrome/common/child_process_logging_win.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/common/plugin_messages.h View 4 chunks +0 lines, -5 lines 0 comments Download
M chrome/plugin/npobject_proxy.h View 4 chunks +2 lines, -8 lines 0 comments Download
M chrome/plugin/npobject_proxy.cc View 9 chunks +11 lines, -20 lines 0 comments Download
M chrome/plugin/npobject_stub.h View 3 chunks +1 line, -6 lines 0 comments Download
M chrome/plugin/npobject_stub.cc View 10 chunks +9 lines, -19 lines 0 comments Download
M chrome/plugin/npobject_util.h View 2 chunks +4 lines, -9 lines 0 comments Download
M chrome/plugin/npobject_util.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M chrome/plugin/webplugin_delegate_stub.h View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/plugin/webplugin_delegate_stub.cc View 6 chunks +2 lines, -12 lines 0 comments Download
M chrome/plugin/webplugin_proxy.h View 3 chunks +1 line, -5 lines 0 comments Download
M chrome/plugin/webplugin_proxy.cc View 6 chunks +9 lines, -12 lines 0 comments Download
M chrome/renderer/render_view.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.h View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 9 chunks +6 lines, -11 lines 0 comments Download
A + chrome\renderer\renderer_logging.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome\renderer\renderer_logging_linux.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome\renderer\renderer_logging_mac.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome\renderer\renderer_logging_mac_unittest.mm View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome\renderer\renderer_logging_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nicolas Sylvain
11 years, 5 months ago (2009-07-08 20:15:01 UTC) #1
jam
11 years, 5 months ago (2009-07-08 20:34:35 UTC) #2 
argh, sorry about that.  it passed on the linux/mac trybots but the windows one
had compile failures because of VS.  I'll retry it again.

Powered by Google App Engine
This is Rietveld 408576698