Issue 155233: Quick fix for linux shared build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155233: Quick fix for linux shared build. (Closed)

Created:
11 years, 5 months ago by Craig

Modified:
9 years, 7 months ago

Reviewers:
Sverrir

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Quick fix for linux shared build. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20365

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	printing/page_overlays.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Craig

Sverrir: can you review this please? The shared build is breaking in libprinting.so because printing::PrintedDocument::page_count() ...

11 years, 5 months ago (2009-07-09 17:59:46 UTC) #1

Sverrir

11 years, 5 months ago (2009-07-09 18:42:14 UTC) #2

LGTM

Sorry to break the build this way - I compiled it myself on linux and it worked
so I'm surprised by the breakage.
You are right in that this is not currently used but I added this to the other
platform builds so we can see if any new changes break portability.

Thanks for fixing!
Sverrir

Expand Messages | Collapse Messages