Issue 155231: Disk cache: Additional code cleanup after CL 20067.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155231: Disk cache: Additional code cleanup after CL 20067. (Closed)

Created:
11 years, 5 months ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disk cache: Additional code cleanup after CL 20067. BUG=15596 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20190

Patch Set 1 #

Total comments: 2

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -20 lines)			Patch
	M	net/disk_cache/backend_impl.cc	View		6 chunks	+10 lines, -20 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

LGTM http://codereview.chromium.org/155231/diff/1/2 File net/disk_cache/backend_impl.cc (right): http://codereview.chromium.org/155231/diff/1/2#newcode1133 Line 1133: parent_entry = NULL; maybe here and below ...

11 years, 5 months ago (2009-07-08 20:25:09 UTC) #2

rvargas (doing something else)

11 years, 5 months ago (2009-07-08 20:49:43 UTC) #3

Thanks.

http://codereview.chromium.org/155231/diff/1/2
File net/disk_cache/backend_impl.cc (right):

http://codereview.chromium.org/155231/diff/1/2#newcode1133
Line 1133: parent_entry = NULL;
On 2009/07/08 20:25:09, Nicolas Sylvain wrote:
> maybe here and below you could use .reset()?

there is no reset() for scoped_refptr

Expand Messages | Collapse Messages