Issue 155228: Adds tab pinning to TabStripModel. This is just the model side of...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155228: Adds tab pinning to TabStripModel. This is just the model side of... (Closed)

Created:
11 years, 5 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com, darin (slow to review), Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Adds tab pinning to TabStripModel. This is just the model side of things (and tests), no UI yet. The model enforces that all pinned tabs occur at the beginning of the model. For example, if there are no pinned tabs and you pin the 10th tab, it is moved to the front of the tab strip. Similarly inserting a tab before the last pinned tab implicitly pins it. Moving a pinned tab beyond the set of pinned tabs implicitly unpins it. I'll file a bug on this when the site allows me to. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20181

Patch Set 1 #

Total comments: 2

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+435 lines, -42 lines)			Patch
M	chrome/browser/tabs/tab_strip_model.h	View	10 chunks	+70 lines, -19 lines	2 comments	Download
M	chrome/browser/tabs/tab_strip_model.cc	View	8 chunks	+101 lines, -19 lines	0 comments	Download
M	chrome/browser/tabs/tab_strip_model_order_controller.cc	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/tabs/tab_strip_model_unittest.cc	View	11 chunks	+254 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/glue/window_open_disposition.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

11 years, 5 months ago (2009-07-08 18:42:43 UTC) #2

LGTM

http://codereview.chromium.org/155228/diff/1/6
File chrome/browser/tabs/tab_strip_model.h (right):

http://codereview.chromium.org/155228/diff/1/6#newcode106
Line 106: // NOTE: this is only invoked if the tab doesn't move as a result of
it's
its

http://codereview.chromium.org/155228/diff/1/6#newcode417
Line 417: void SetTabPinned(int index, bool value);
bool pinned

Expand Messages | Collapse Messages