Issue 155218: Cleanup v8.gyp. This also drops a bunch of unused targets (the shell, d8,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155218: Cleanup v8.gyp. This also drops a bunch of unused targets (the shell, d8, (Closed)

Created:
11 years, 5 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Joel Stanley (old), Kasper Lund

CC:
v8-dev

Visibility:
Public.

Description

Cleanup v8.gyp. This also drops a bunch of unused targets (the shell, d8, etc). There are now two gyp variables to control whether we build snapshots and which target we are building for. This allows you to easily cross-compile for arm and disable snapshots. Patch by Joel Stanley. Original review: http://codereview.chromium.org/149243

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+337 lines, -570 lines)			Patch
	M	tools/gyp/v8.gyp	View		5 chunks	+337 lines, -570 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM. Let's try it on the build bots.

Expand Messages | Collapse Messages