Issue 155217: DevTools: Push context id to the client on 'window object cleared' event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155217: DevTools: Push context id to the client on 'window object cleared' event. (Closed)

Created:
11 years, 5 months ago by pfeldman

Modified:
9 years, 7 months ago

Reviewers:
yurys

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DevTools: Push context id to the client on 'window object cleared' event. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20146

Patch Set 4 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -25 lines)			Patch
M	webkit/glue/devtools/debugger_agent.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/glue/devtools/debugger_agent_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/devtools/js/debugger_agent.js	View	1 2	4 chunks	+11 lines, -21 lines	0 comments	Download
M	webkit/glue/devtools/js/devtools.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/webdevtoolsagent_impl.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yurys

http://codereview.chromium.org/155217/diff/1007/13 File webkit/glue/devtools/js/debugger_agent.js (right): http://codereview.chromium.org/155217/diff/1007/13#newcode543 Line 543: // We've just received context id. This means ...

11 years, 5 months ago (2009-07-08 14:42:26 UTC) #2

pfeldman

11 years, 5 months ago (2009-07-08 15:11:08 UTC) #4

http://codereview.chromium.org/155217/diff/1007/13
File webkit/glue/devtools/js/debugger_agent.js (right):

http://codereview.chromium.org/155217/diff/1007/13#newcode543
Line 543: // We've just received context id. This means that we are here from
the
On 2009/07/08 14:42:27, Yury Semikhatsky wrote:
> The comment is misleading as long as the id is requested when devtools window
is
> opened for an already loaded page.

Done.

Expand Messages | Collapse Messages

Issue 155217: DevTools: Push context id to the client on 'window object cleared' event. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages