Issue 155216: Support running app_unittests under Valgrind

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155216: Support running app_unittests under Valgrind (Closed)

Created:
11 years, 5 months ago by Nirnimesh

Modified:
9 years, 7 months ago

Reviewers:
dank, M-A Ruel

CC:
chromium-reviews_googlegroups.com, dank, Nirnimesh

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Support running app_unittests under Valgrind Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20290

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	tools/valgrind/chrome_tests.py	View		2 chunks	+4 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

11 years, 5 months ago (2009-07-08 14:33:14 UTC) #2

lgtm

http://codereview.chromium.org/155216/diff/1/2
File tools/valgrind/chrome_tests.py (right):

http://codereview.chromium.org/155216/diff/1/2#newcode91
Line 91: "app": self.TestApp,               "app_unittests": self.TestApp,
alignment

Expand Messages | Collapse Messages