Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 155214: Add 'preserve trailing view size' capability into the SingleSplitView.... (Closed)

Created:
11 years, 5 months ago by pfeldman
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Add 'resize_leading_on_bounds_change' property into the SingleSplitView. When it is turned on, leading component is resized when split view gets new bounds. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20258

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M chrome/browser/views/bookmark_manager_view.cc View 2 1 chunk +1 line, -0 lines 0 comments Download
M views/controls/single_split_view.h View 1 2 3 chunks +12 lines, -0 lines 0 comments Download
M views/controls/single_split_view.cc View 1 2 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
pfeldman
11 years, 5 months ago (2009-07-08 13:07:21 UTC) #1
sky
http://codereview.chromium.org/155214/diff/1/2 File views/controls/single_split_view.h (right): http://codereview.chromium.org/155214/diff/1/2#newcode44 Line 44: void set_preserve_trailing_size(bool preserve_trailing_size) { Might I suggest the ...
11 years, 5 months ago (2009-07-08 16:05:23 UTC) #2
pfeldman
Thanks for the review. http://codereview.chromium.org/155214/diff/1/2 File views/controls/single_split_view.h (right): http://codereview.chromium.org/155214/diff/1/2#newcode44 Line 44: void set_preserve_trailing_size(bool preserve_trailing_size) { ...
11 years, 5 months ago (2009-07-08 16:38:47 UTC) #3
sky
11 years, 5 months ago (2009-07-08 16:42:16 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698