Issue 155207: A quick fix for Issue 15971....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155207: A quick fix for Issue 15971.... (Closed)

Created:
11 years, 5 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, Evan Stade

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

A quick fix for Issue 15971. This is another my stupid mistake that my r19238 sends a Char event even when its text[] member does not contains any characters. I mis-understoold I needed to send a Char event every time when gtk_keyval_to_unicode() returns 0 to avoid Issue 15024. But this is wrong. (Page Down, Page Up, Arrow Keys work without Char events. Only return keys need Char events.) BUG=15971 "drop down list moves 2 positions when using the keyboard". TEST=Open the attached test-case Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20370

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	chrome/browser/renderer_host/render_widget_host_view_gtk.cc	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lg

Expand Messages | Collapse Messages