DevTools: remove extensions-related workaround from the docked devtools windo...

chrome/browser/extensions/extension_browser_event_router.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_browser_event_router.h"
 
 #include "base/json_writer.h"
 #include "base/values.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/profile.h"
@@ skipping 250 matching lines @@
   std::string json_args;
   JSONWriter::Write(&args, false, &json_args);
 
   DispatchEvent(contents->profile(), events::kOnTabMoved, json_args);
 }
 
 void ExtensionBrowserEventRouter::TabUpdated(TabContents* contents,
                                              bool did_navigate) {
   int tab_id = ExtensionTabUtil::GetTabId(contents);
   std::map<int, TabEntry>::iterator i = tab_entries_.find(tab_id);
-  CHECK(tab_entries_.end() != i);
+  if(tab_entries_.end() == i) {
+    // TODO(rafaelw): Unregister EBER on TAB_CONTENTS_DESTROYED in order
+    // not to receive NAV_ENTRY_COMMITTED from objects that are allocated
+    // at the same address as previously deleted TabContents.
+    //
+    // The problem here is that NAV_ENTRY_COMMITTED is issued by the navigation
+    // controller independently from tabstrip model. One should not rely upon
+    // TabStripModelObserver events when registering / unregistering
+    // tab contents events' handlers.
+    registrar_.Remove(this, NotificationType::NAV_ENTRY_COMMITTED,
+                      Source<NavigationController>(&contents->controller()));
+    return;
+  }
   TabEntry& entry = i->second;
 
   DictionaryValue* changed_properties = NULL;
   if (did_navigate)
     changed_properties = entry.DidNavigate(contents);
   else
     changed_properties = entry.UpdateLoadState(contents);
 
   if (changed_properties) {
     // The state of the tab (as seen from the extension point of view) has
@@ skipping 42 matching lines @@
   data->Set(tab_keys::kTabUrlKey, Value::CreateStringValue(url));
   object_args->Set(tab_keys::kDataKey, data);
 
   args.Append(object_args);
 
   std::string json_args;
   JSONWriter::Write(&args, false, &json_args);
 
   DispatchEvent(profile, events::kOnPageActionExecuted, json_args);
 }