Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 155205: Change the name of the Object.prototype.inherits function in... (Closed)

Created:
11 years, 5 months ago by Kasper Lund
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Change the name of the Object.prototype.inherits function in the DeltaBlue benchmark to inheritsFrom to avoid name clashes when running in Chromium with extensions enabled. See http://crbug.com/11797. Committed: http://code.google.com/p/v8/source/detail?r=2386

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M benchmarks/README.txt View 1 chunk +4 lines, -1 line 0 comments Download
M benchmarks/deltablue.js View 7 chunks +7 lines, -7 lines 0 comments Download
M benchmarks/revisions.html View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Kasper Lund
11 years, 5 months ago (2009-07-08 07:01:02 UTC) #1
Erik Corry
11 years, 5 months ago (2009-07-08 07:30:36 UTC) #2
Looks necessary to me.

Powered by Google App Engine
This is Rietveld 408576698