Fix: Position always off-screen when starting up...

Fix: Position always off-screen when starting up

Fixed the offset-by-taskbar logic.

Tested with dual monitors, trying left-right and up-down monitor layouts.

TEST=Use dual monitors (first:left, second:right) and open, close, and reopen Chromium in the second (right) window. Without this change, the window appears far to the right from the last location.

BUG=15199
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20246

[Yuzo, 2009-07-08 05:35:40]

Hi, Peter,

Sorry for the regression.
Can you review this patch?

Yuzo

[Peter Kasting, 2009-07-08 16:21:29]

Code change LGTM.  Is there an added test you can put in the testcases list that
will catch this regression?

[Yuzo, 2009-07-09 00:48:21]

Hi, Peter,

Thank you for the review.

I had tried to add a test but found that GetWindowPlacement and
GetWindowInfo are native API calls. Adding an abstraction layer
for testing looked a bit overkill to me. Any ideas?

Yuzo 

On 2009/07/08 16:21:29, pkasting wrote:
> Code change LGTM.  Is there an added test you can put in the testcases list
that
> will catch this regression?

[Peter Kasting, 2009-07-09 00:51:15]

On 2009/07/09 00:48:21, Yuzo wrote:
> I had tried to add a test but found that GetWindowPlacement and
> GetWindowInfo are native API calls. Adding an abstraction layer
> for testing looked a bit overkill to me. Any ideas?

Hmm.  I think I agree.  Let's just get this in w/o the test.