Issue 155194: linux: port Jankometer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155194: linux: port Jankometer (Closed)

Created:
11 years, 5 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

linux: port Jankometer Originally I had split it into multiple files, but I think it's cleaner to just use one. (I want to use this for measuring plugin jank.) BUG=8077

Patch Set 1 #

Patch Set 2 : cleaned up #

Patch Set 3 : ok #

Patch Set 4 : redone #

Patch Set 5 : minus dead files #

Total comments: 1

Patch Set 6 : ok #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+144 lines, -25 lines)			Patch
M	chrome/browser/jankometer.h	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/jankometer.cc	View	1 2 3 4 5	5 chunks	+59 lines, -19 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 2 3	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/common/gtk_util.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/common/gtk_util.cc	View		1 chunk	+73 lines, -0 lines	0 comments	Download
M	chrome/common/temp_scaffolding_stubs.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

actually, hold off, the windows code here is no good yet

11 years, 5 months ago (2009-07-08 01:16:24 UTC) #2

Evan Martin

argh, now that i've written a linux impl i want to refactor, hold off again

11 years, 5 months ago (2009-07-08 02:05:10 UTC) #4

Evan Stade

11 years, 5 months ago (2009-07-08 03:51:02 UTC) #5

lgtm as discussed in irc

http://codereview.chromium.org/155194/diff/27/1014
File chrome/browser/jankometer.cc (right):

http://codereview.chromium.org/155194/diff/27/1014#newcode173
Line 173: 
maybe delete L173

Expand Messages | Collapse Messages