Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2351)

Unified Diff: chrome/browser/extensions/extensions_service.cc

Issue 155187: ExtensionsServiceBackend::GarbageCollectionExtensions() makes a local copy of install_directory_ (Closed)
Patch Set: GarbageCollect makes local copy of install_directory_ Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extensions_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extensions_service.cc
diff --git a/chrome/browser/extensions/extensions_service.cc b/chrome/browser/extensions/extensions_service.cc
index b44c6309663353a9fa2098ee21c0049694b0b1d7..4094ebfbe40b4e2d04d1fe16f14b0bcb0c9e9733 100644
--- a/chrome/browser/extensions/extensions_service.cc
+++ b/chrome/browser/extensions/extensions_service.cc
@@ -559,14 +559,15 @@ void ExtensionsServiceBackend::GarbageCollectExtensions(
// Nothing to clean up if it doesn't exist.
if (!file_util::DirectoryExists(install_directory_))
return;
-
- file_util::AbsolutePath(&install_directory_);
+
+ FilePath install_directory_absolute(install_directory_);
+ file_util::AbsolutePath(&install_directory_absolute);
LOG(INFO) << "Loading installed extensions...";
// Find all child directories in the install directory and load their
// manifests. Post errors and results to the frontend.
- file_util::FileEnumerator enumerator(install_directory_,
+ file_util::FileEnumerator enumerator(install_directory_absolute,
false, // Not recursive.
file_util::FileEnumerator::DIRECTORIES);
FilePath extension_path;
« no previous file with comments | « no previous file | chrome/browser/extensions/extensions_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698