Issue 155187: ExtensionsServiceBackend::GarbageCollectionExtensions() makes a local copy of install_directory_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155187: ExtensionsServiceBackend::GarbageCollectionExtensions() makes a local copy of install_directory_ (Closed)

Created:
11 years, 5 months ago by rafaelw

Modified:
9 years, 7 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

ExtensionsServiceBackend::GarbageCollectionExtensions() makes a local copy of install_directory_. It was forcing the persistent copy to an absolute path which was causing the ExternsionsService and ExtensionsPrefs install_directory_ values to diverge. Re-enable ExternalInstallPref on mac. TBR=mpcomplete Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20214

Patch Set 1 #

Patch Set 2 : GarbageCollect makes local copy of install_directory_ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -9 lines)			Patch
	M	chrome/browser/extensions/extensions_service.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download
	M	chrome/browser/extensions/extensions_service_unittest.cc	View	1	2 chunks	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rafaelw

The previous version was causing failures on linux. I believe this version address the root ...

11 years, 5 months ago (2009-07-08 23:57:26 UTC) #3

LG

Expand Messages | Collapse Messages