Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 155172: Start using WebCursorInfo from the WebKit API. WebCursorInfo is a... (Closed)

Created:
11 years, 5 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews_googlegroups.com, John Grabowski, darin (slow to review), brettw
Visibility:
Public.

Description

Start using WebCursorInfo from the WebKit API. WebCursorInfo is a lightweight struct containing a description of a cursor that the embedder should render. WebCursor still exists. Instead of WebCursor initializing from a PlatformCursor, it now initializes from a WebCursorInfo. TEST=none BUG=10039 R=jam Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20194

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+552 lines, -296 lines) Patch
M chrome/plugin/webplugin_delegate_stub.cc View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M chrome/renderer/print_web_view_helper.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/render_widget.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/render_widget.cc View 1 2 3 chunks +7 lines, -1 line 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M webkit/api/public/WebCursorInfo.h View 1 2 3 5 chunks +20 lines, -6 lines 0 comments Download
M webkit/api/public/WebImage.h View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
A webkit/api/src/WebCursorInfo.cpp View 1 5 1 chunk +99 lines, -0 lines 0 comments Download
M webkit/api/src/WebImageCG.cpp View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
M webkit/api/src/WebImageSkia.cpp View 1 2 2 chunks +16 lines, -0 lines 0 comments Download
M webkit/glue/chrome_client_impl.h View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M webkit/glue/chrome_client_impl.cc View 1 2 4 chunks +4 lines, -2 lines 0 comments Download
M webkit/glue/chromium_bridge_impl.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M webkit/glue/glue_util.h View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
M webkit/glue/glue_util.cc View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl_gtk.cc View 3 chunks +3 lines, -1 line 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl_mac.mm View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M webkit/glue/webcursor.h View 1 2 3 chunks +10 lines, -5 lines 0 comments Download
M webkit/glue/webcursor.cc View 1 2 5 chunks +61 lines, -28 lines 0 comments Download
M webkit/glue/webcursor_gtk.cc View 1 2 3 chunks +47 lines, -50 lines 0 comments Download
M webkit/glue/webcursor_mac.mm View 1 2 2 chunks +113 lines, -92 lines 0 comments Download
M webkit/glue/webcursor_win.cc View 1 2 3 chunks +64 lines, -69 lines 0 comments Download
M webkit/glue/webplugin_delegate.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/webplugin_impl.cc View 1 2 7 chunks +7 lines, -7 lines 0 comments Download
M webkit/glue/webwidget_delegate.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/glue/webworker_impl.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/mac/test_webview_delegate.mm View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_gtk.cc View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_win.cc View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M webkit/webkit.gyp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
darin (slow to review)
11 years, 5 months ago (2009-07-08 21:17:48 UTC) #1
jam
11 years, 5 months ago (2009-07-08 21:45:52 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698