Issue 155168: Fix for the default browser info-bar showing after first run

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155168: Fix for the default browser info-bar showing after first run (Closed)

Created:
11 years, 5 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
kuchhal

CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google), cpu_(ooo_6.6-7.5)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Some code had been removed from FirstRun::IsChromeFirstRun() so that it may return true then false when later invoked.This caused a bug where we would show the info-bar warning that Chromium is not the default browser after the first run.This patch resurrects that code and changes the first run UI, as it was relying on that behavior.BUG=http://crbug.com/15833TEST=Make IE or Firefox your default browser. Open Chromium so it shows the 1st run UI. Unselect the "make chromium my default browser" button, then press start. When Chromium shows up, there should be no info-bar warning you Chromium is not your default browser. Also test that the first run UI still works as expected. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20151

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -16 lines)			Patch
M	chrome/browser/browser_main.cc	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/first_run.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/first_run.cc	View		1 chunk	+12 lines, -2 lines	0 comments	Download
MM	chrome/browser/first_run_gtk.cc	View		3 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/first_run_mac.mm	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/first_run_win.cc	View	1	2 chunks	+8 lines, -2 lines	0 comments	Download
M	chrome/browser/views/first_run_view.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/views/first_run_view.cc	View		2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/common/temp_scaffolding_stubs.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm.

Expand Messages | Collapse Messages

Issue 155168: Fix for the default browser info-bar showing after first run (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages