Issue 155166: The WebURLResponse will be null if the network request fails. So, a null che...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155166: The WebURLResponse will be null if the network request fails. So, a null che... (Closed)

Created:
11 years, 5 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

The WebURLResponse will be null if the network request fails. So, a null check here is warranted. I failed to translate this over when adapting this code to the new interfaces. The tight coupling with WebView, WebFrame and WebViewDelegate makes this code non-trivial to test. My next patch was anyways to remove those dependencies. I'll circle around at that point with some unit tests for these classes. R=brettw TEST=none BUG=16144 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20082

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	webkit/glue/alt_404_page_resource_fetcher.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	webkit/glue/alt_error_page_resource_fetcher.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

LGTM Does it make sense to add comments to this effect so you don't make ...

11 years, 5 months ago (2009-07-07 21:22:56 UTC) #2

darin (slow to review)

> Does it make sense to add comments to this effect so you don't make ...

11 years, 5 months ago (2009-07-07 21:25:23 UTC) #3

Expand Messages | Collapse Messages