Issue 155164: Give page/app menu native menu bar feel....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155164: Give page/app menu native menu bar feel.... (Closed)

Created:
11 years, 5 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Elliot Glaysher, Evan Martin

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Give page/app menu native menu bar feel. Allow keyboard and mouse navigation between the two while one is open. BUG=none TEST=the page and wrench menus feel like a native menubar Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20095

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -0 lines)			Patch
	M	chrome/browser/gtk/browser_toolbar_gtk.h	View		2 chunks	+13 lines, -0 lines	0 comments	Download
	M	chrome/browser/gtk/browser_toolbar_gtk.cc	View		4 chunks	+63 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

11 years, 5 months ago (2009-07-07 21:09:25 UTC) #2

On 2009/07/07 21:06:14, Evan Stade wrote:
> sad how long it took me to get this sorta right

LGTM, though I don't totally understand how OnPageAppMenuMoveCurrent works.

Expand Messages | Collapse Messages