Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 155151: Hook up the prefs for the optional home buttons and page/wrench buttons. Move... (Closed)

Created:
11 years, 5 months ago by pink (ping after 24hrs)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)
Visibility:
Public.

Description

Hook up the prefs for the optional home buttons and page/wrench buttons. Move default registration of this pref out of platform code and into shared code to avoid having to do it in at least 3 places. Fix gradient buttons to not draw their borders unless asked. BUG=13151 TEST=showing/hiding home button and page/wrench buttons should work. Menus for page/wrench should work except for a few straggler items that aren't yet implemented even in the main menubar. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20052

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1532 lines, -44 lines) Patch
M chrome/app/nibs/en.lproj/Toolbar.xib View 23 chunks +1307 lines, -25 lines 0 comments Download
A chrome/app/theme/home.pdf View Binary file 0 comments Download
A chrome/app/theme/menu_chrome.pdf View Binary file 0 comments Download
A chrome/app/theme/menu_page.pdf View Binary file 0 comments Download
M chrome/browser/app_controller_mac.mm View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/browser.cc View 1 chunk +11 lines, -0 lines 0 comments Download
MM chrome/browser/cocoa/gradient_button_cell.mm View 1 chunk +11 lines, -4 lines 0 comments Download
M chrome/browser/cocoa/preferences_window_controller_unittest.mm View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/cocoa/toolbar_controller.h View 3 chunks +22 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/toolbar_controller.mm View 6 chunks +127 lines, -5 lines 2 comments Download
M chrome/browser/cocoa/toolbar_controller_unittest.mm View 4 chunks +50 lines, -3 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pink (ping after 24hrs)
11 years, 5 months ago (2009-07-07 17:46:36 UTC) #1
rohitrao (ping after 24h)
LGTM http://codereview.chromium.org/155151/diff/1/9 File chrome/browser/cocoa/toolbar_controller.mm (right): http://codereview.chromium.org/155151/diff/1/9#newcode55 Line 55: // notification back to the BWC. s/BWC/ToolbarController/ ...
11 years, 5 months ago (2009-07-07 18:10:46 UTC) #2
pink (ping after 24hrs)
11 years, 5 months ago (2009-07-07 18:12:17 UTC) #3
http://codereview.chromium.org/155151/diff/1/9
File chrome/browser/cocoa/toolbar_controller.mm (right):

http://codereview.chromium.org/155151/diff/1/9#newcode55
Line 55: // notification back to the BWC.
On 2009/07/07 18:10:46, rohitrao wrote:
> s/BWC/ToolbarController/ ?

Done.

Powered by Google App Engine
This is Rietveld 408576698