DevTools: store devtools split offset only when devtools is being hidden....

chrome/browser/views/frame/browser_view.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/frame/browser_view.h"
 
 #if defined(OS_LINUX)
 #include <gtk/gtk.h>
 #endif
 
@@ skipping 584 matching lines @@
   GetWidget()->SetBounds(bounds);
 }
 
 void BrowserView::Close() {
   frame_->GetWindow()->Close();
 
   BubbleSet::iterator bubble = browser_bubbles_.begin();
   for (; bubble != browser_bubbles_.end(); ++bubble) {
     (*bubble)->BrowserWindowClosed();
   }
-
-  g_browser_process->local_state()->SetInteger(
-      prefs::kDevToolsSplitLocation, contents_split_->divider_offset());
 }
 
 void BrowserView::Activate() {
   frame_->GetWindow()->Activate();
 }
 
 bool BrowserView::IsActive() const {
   return frame_->GetWindow()->IsActive();
 }
 
@@ skipping 811 matching lines @@
   AddChildView(toolbar_);
   toolbar_->SetID(VIEW_ID_TOOLBAR);
   toolbar_->Init(browser_->profile());
   toolbar_->SetAccessibleName(l10n_util::GetString(IDS_ACCNAME_TOOLBAR));
 
   infobar_container_ = new InfoBarContainer(this);
   AddChildView(infobar_container_);
 
   contents_container_ = new TabContentsContainer;
   devtools_container_ = new TabContentsContainer;
+  devtools_container_->SetVisible(false);
   contents_split_ = new views::SingleSplitView(
       contents_container_,
       devtools_container_,
       views::SingleSplitView::VERTICAL_SPLIT);
   AddChildView(contents_split_);
   set_contents_view(contents_split_);
 
   status_bubble_.reset(new StatusBubbleViews(GetWidget()));
 
   extension_shelf_ = new ExtensionShelf(browser_.get());
@@ skipping 151 matching lines @@
   // TODO(beng): Remove this function once the interface between
   //             InfoBarContainer, DownloadShelfView and TabContents and this
   //             view is sorted out.
   return true;
 }
 
 void BrowserView::UpdateDevToolsForContents(TabContents* tab_contents) {
   TabContents* devtools_contents =
       DevToolsWindow::GetDevToolsContents(tab_contents);
   devtools_container_->ChangeTabContents(devtools_contents);
+  if (!devtools_contents && devtools_container_->IsVisible()) {
+    // Store split offset when hiding devtools window only.
+    g_browser_process->local_state()->SetInteger(
+        prefs::kDevToolsSplitLocation, contents_split_->divider_offset());
+  }
   devtools_container_->SetVisible(devtools_contents != NULL);
   contents_split_->Layout();
 }
 
 void BrowserView::UpdateUIForContents(TabContents* contents) {
   bool needs_layout = MaybeShowBookmarkBar(contents);
   needs_layout |= MaybeShowInfoBar(contents);
   if (needs_layout)
     Layout();
 }
@@ skipping 229 matching lines @@
 
 // static
 FindBar* BrowserWindow::CreateFindBar(Browser* browser) {
   return browser::CreateFindBar(static_cast<BrowserView*>(browser->window()));
 }
 
 // static
 void BrowserList::AllBrowsersClosed() {
   views::Window::CloseAllSecondaryWindows();
 }