Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 155136: Add the symbol and source server scripts. (Closed)

Created:
11 years, 5 months ago by Dean McNamee
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add the symbol and source server scripts.

Patch Set 1 #

Total comments: 10

Patch Set 2 : review feedback #

Patch Set 3 : review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4034 lines, -0 lines) Patch
A tools/symsrc/COPYING-pefile View 1 chunk +27 lines, -0 lines 0 comments Download
A tools/symsrc/img_fingerprint.py View 1 1 chunk +28 lines, -0 lines 0 comments Download
A tools/symsrc/pdb_fingerprint_from_img.py View 1 1 chunk +57 lines, -0 lines 0 comments Download
A tools/symsrc/pefile.py View 1 chunk +3729 lines, -0 lines 0 comments Download
A tools/symsrc/source_index.py View 1 1 chunk +193 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dean McNamee
11 years, 5 months ago (2009-07-07 12:39:20 UTC) #1
M-A Ruel
http://codereview.chromium.org/155136/diff/1/3 File tools/symsrc/README.google (right): http://codereview.chromium.org/155136/diff/1/3#newcode1 Line 1: These files are related to the symbol and ...
11 years, 5 months ago (2009-07-07 13:25:12 UTC) #2
Dean McNamee
Updated, you'll have to live with the 1 long line in the string literal.
11 years, 5 months ago (2009-07-07 13:35:41 UTC) #3
M-A Ruel
11 years, 5 months ago (2009-07-07 13:40:09 UTC) #4
lgtm

we'll need to find a way to remove the duplicate sources.

Powered by Google App Engine
This is Rietveld 408576698