src/handles.cc - Issue 155135: Change a few sites where the Handle<T>(NULL) constructor is used so...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/handles.cc

Issue 155135: Change a few sites where the Handle<T>(NULL) constructor is used so... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/handles.cc

===================================================================

--- src/handles.cc (revision 2368)

+++ src/handles.cc (working copy)

@@ -372,10 +372,10 @@

Handle<JSValue> GetScriptWrapper(Handle<Script> script) {

- Handle<Object> cache(reinterpret_cast<Object**>(script->wrapper()->proxy()));

- if (!cache.is_null()) {

+ if (script->wrapper()->proxy() != NULL) {

// Return the script wrapper directly from the cache.

- return Handle<JSValue>(JSValue::cast(*cache));

+ return Handle<JSValue>(

+ reinterpret_cast<JSValue**>(script->wrapper()->proxy()));

}

// Construct a new script wrapper.

« no previous file with comments | « src/handles.h ('k') | src/ia32/assembler-ia32.cc » ('j') | no next file with comments »