Fix tools/valgrind/chrome_tests.sh to always use --log-file option...

Fix tools/valgrind/chrome_tests.sh to always use --log-file option
so fork() doesn't corrupt log files; lets --generate_suppressions 
work even with the hacky valgrind fix that makes anything but --log-file
crash on child of fork().

Also avoid killing user desktop session if zygote dies!

BUG=none, but related to fix for http://crbug.com/15771
TEST=patch valgrind with fork workaround; sh tools/valgrind/chrome_tests.sh --generate_suppressions -t ui logs you out on linux without this.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20024

[dank, 2009-07-07 05:02:53]

Hi Timur, 
this goes along with the valgrind patch you're looking at, kind of.

Also fixes a very amusing bug: if the zygote fails to launch,
chrome logs you out of Linux!

[the_wrong_timurrrr, 2009-07-07 08:38:53]

http://codereview.chromium.org/155130/diff/1/3
File base/process_util_posix.cc (right):

http://codereview.chromium.org/155130/diff/1/3#newcode68
Line 68: if (process_id < 0) {
process_id == 0 is allowed in release mode and disallowed in debug mode. Typo?

http://codereview.chromium.org/155130/diff/1/2
File tools/valgrind/valgrind_test.py (right):

http://codereview.chromium.org/155130/diff/1/2#newcode139
Line 139: if self._generate_suppressions:
I'd prefer having a separate methods like GenerateSuppressions(filenames) and
Analyze(filenames).
This way it would be easier to override/extend the logic for other tools like
ThreadSanitizer

[the_wrong_timurrrr, 2009-07-07 13:59:23]

http://codereview.chromium.org/155130/diff/1/3
File base/process_util_posix.cc (right):

http://codereview.chromium.org/155130/diff/1/3#newcode68
Line 68: if (process_id < 0) {
On 2009/07/07 08:38:53, timurrrr wrote:
> process_id == 0 is allowed in release mode and disallowed in debug mode. Typo?

Done.