Issue 155109: - Update comments and fix a small glitch in the ARM disassembler....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155109: - Update comments and fix a small glitch in the ARM disassembler.... (Closed)

Created:
11 years, 5 months ago by iposva

Modified:
9 years, 4 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

- Update comments and fix a small glitch in the ARM disassembler. - Fix the use of OS::ActivationFrameAlignment() when running with the simulator. Committed: http://code.google.com/p/v8/source/detail?r=2401

Patch Set 1 #

Total comments: 6

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -14 lines)			Patch
M	src/arm/disasm-arm.cc	View	1 chunk	+14 lines, -6 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1 chunk	+16 lines, -3 lines	4 comments	Download
M	src/arm/simulator-arm.cc	View	2 chunks	+21 lines, -5 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/155109/diff/1/4 File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/155109/diff/1/4#newcode299 Line 299: #elif // !defined(V8_HOST_ARCH_ARM) I find the comment ...

11 years, 5 months ago (2009-07-07 08:14:15 UTC) #2

iposva

11 years, 5 months ago (2009-07-08 21:33:26 UTC) #3

http://codereview.chromium.org/155109/diff/1/4
File src/arm/macro-assembler-arm.cc (right):

http://codereview.chromium.org/155109/diff/1/4#newcode299
Line 299: #elif  // !defined(V8_HOST_ARCH_ARM)
On 2009/07/07 08:14:16, Erik Corry wrote:
> I find the comment clearer without the ! here.

Done by avoiding the need for "!".

http://codereview.chromium.org/155109/diff/1/4#newcode305
Line 305: #endif  // !defined(V8_HOST_ARCH_ARM)
On 2009/07/07 08:14:16, Erik Corry wrote:
> And without the ! here.

Done.

http://codereview.chromium.org/155109/diff/1/2
File src/arm/simulator-arm.cc (right):

http://codereview.chromium.org/155109/diff/1/2#newcode1104
Line 1104: Format(instr, "mla'cond's 'rd, 'rm, 'rs, 'rn");
On 2009/07/07 08:14:16, Erik Corry wrote:
> Should be 'rn 'rm 'rs 'rd for similar reasons to the above.
> 

Fixed by copying the whole block out of the disassembler (including the updated
comment.)

Expand Messages | Collapse Messages