Add default browser checking and setting on Linux.

Add default browser checking and setting on Linux.
BUG=11972
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20380

[Mike Mammarella, 2009-07-06 19:25:47]

This won't synthesize a .desktop file yet, but I intend to add that to the
wrapper. Just wanted to get initial feedback on the rest, in case things should
be moved around or anything.

[Mike Mammarella, 2009-07-06 22:51:45]

Now creates a desktop file if there is not one already. Chromium can be set as
the default browser right out of a compile. A packaged version would not need to
create the desktop file as there would already be one present.

[Lei Zhang, 2009-07-08 20:50:48]

http://codereview.chromium.org/155100/diff/23/25
File chrome/browser/shell_integration_linux.cc (right):

http://codereview.chromium.org/155100/diff/23/25#newcode7
Line 7: #include "chrome/browser/shell_integration.h"
I think the header order should be shell_integration.h, c headers, c++ headers,
other headers.

http://codereview.chromium.org/155100/diff/23/25#newcode11
Line 11: #if defined(CHROMIUM_BUILD)
Where is this defined? Maybe add a #include for it rather than depending on
implicit header includes.

http://codereview.chromium.org/155100/diff/23/25#newcode25
Line 25: std::vector<std::string> argv;
#include <vector>

http://codereview.chromium.org/155100/diff/23/25#newcode46
Line 46: std::string output("");
nit: isn't the ("") unnecessary?

http://codereview.chromium.org/155100/diff/23/25#newcode68
Line 68: return getDefaultBrowser().find("irefox") != std::string::npos;
Do we care about iceweasel?

[Mike Mammarella, 2009-07-08 21:14:46]

http://codereview.chromium.org/155100/diff/23/25
File chrome/browser/shell_integration_linux.cc (right):

http://codereview.chromium.org/155100/diff/23/25#newcode7
Line 7: #include "chrome/browser/shell_integration.h"
On 2009/07/08 20:50:48, Lei Zhang wrote:
> I think the header order should be shell_integration.h, c headers, c++
headers,
> other headers.

Done.

http://codereview.chromium.org/155100/diff/23/25#newcode11
Line 11: #if defined(CHROMIUM_BUILD)
On 2009/07/08 20:50:48, Lei Zhang wrote:
> Where is this defined? Maybe add a #include for it rather than depending on
> implicit header includes.

It's defined by the build system (see build/common.gypi) in a -D passed to the
compiler.

http://codereview.chromium.org/155100/diff/23/25#newcode25
Line 25: std::vector<std::string> argv;
On 2009/07/08 20:50:48, Lei Zhang wrote:
> #include <vector>

Done.

http://codereview.chromium.org/155100/diff/23/25#newcode46
Line 46: std::string output("");
On 2009/07/08 20:50:48, Lei Zhang wrote:
> nit: isn't the ("") unnecessary?

Done.

http://codereview.chromium.org/155100/diff/23/25#newcode68
Line 68: return getDefaultBrowser().find("irefox") != std::string::npos;
On 2009/07/08 20:50:48, Lei Zhang wrote:
> Do we care about iceweasel?

We don't on Windows/OS X, but then, maybe that's because iceweasel isn't really
relevant there. Thoughts?

[kuchhal, 2009-07-08 22:10:56]

http://codereview.chromium.org/155100/diff/23/25
File chrome/browser/shell_integration_linux.cc (right):

http://codereview.chromium.org/155100/diff/23/25#newcode11
Line 11: #if defined(CHROMIUM_BUILD)
Actually I don't think we use CHROMIUM_BUILD explicitly any where. Usually the
preferred way is:
#if defined(GOOGLE_CHROME_BUILD)
  do something
#else
  do something else
Until we really have a port other than Google Chrome that we maintain in our
repository the default case is always assumed to be Chromium.
On 2009/07/08 21:14:46, Mike Mammarella wrote:
> On 2009/07/08 20:50:48, Lei Zhang wrote:
> > Where is this defined? Maybe add a #include for it rather than depending on
> > implicit header includes.
> 
> It's defined by the build system (see build/common.gypi) in a -D passed to the
> compiler.

[Mike Mammarella, 2009-07-08 22:35:14]

http://codereview.chromium.org/155100/diff/23/25
File chrome/browser/shell_integration_linux.cc (right):

http://codereview.chromium.org/155100/diff/23/25#newcode11
Line 11: #if defined(CHROMIUM_BUILD)
On 2009/07/08 22:10:56, kuchhal wrote:
> Actually I don't think we use CHROMIUM_BUILD explicitly any where. Usually the
> preferred way is:
> #if defined(GOOGLE_CHROME_BUILD)
>   do something
> #else
>   do something else
> Until we really have a port other than Google Chrome that we maintain in our
> repository the default case is always assumed to be Chromium.
> On 2009/07/08 21:14:46, Mike Mammarella wrote:
> > On 2009/07/08 20:50:48, Lei Zhang wrote:
> > > Where is this defined? Maybe add a #include for it rather than depending
on
> > > implicit header includes.
> > 
> > It's defined by the build system (see build/common.gypi) in a -D passed to
the
> > compiler.
> 
> 

Done.

[Michael Moss, 2009-07-10 17:02:51]

LGTM