Issue 155099: Don't install the RWHVMac into the view hierarchy until everything has been p...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155099: Don't install the RWHVMac into the view hierarchy until everything has been p... (Closed)

Created:
11 years, 5 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Avi (use Gerrit), rohitrao (ping after 24h)

CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Don't install the RWHVMac into the view hierarchy until everything has been properly sized. This avoids sending spurrious resize message with incorrect sizes to the renderer. BUG=15717 TEST=pages should always be the correct size when loaded in bg or foreground. No more flashing a small size then redrawing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19973

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -3 lines)			Patch
M	chrome/browser/cocoa/tab_contents_controller.h	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/tab_contents_controller.mm	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/tab_strip_controller.mm	View	1 chunk	+6 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

lg http://codereview.chromium.org/155099/diff/1/2 File chrome/browser/cocoa/tab_strip_controller.mm (right): http://codereview.chromium.org/155099/diff/1/2#newcode85 Line 85: // spurrious default size loaded from the ...

11 years, 5 months ago (2009-07-06 19:30:03 UTC) #2

LG

Expand Messages | Collapse Messages