Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/browser/gtk/task_manager_gtk.cc

Issue 155098: Activate the currently selected process when the user double clicks the task ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/gtk/task_manager_gtk.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/task_manager_gtk.cc
===================================================================
--- chrome/browser/gtk/task_manager_gtk.cc (revision 19957)
+++ chrome/browser/gtk/task_manager_gtk.cc (working copy)
@@ -59,7 +59,6 @@
}
int TaskManagerColumnIDToResourceID(int id) {
- printf("id: %d\n", id);
switch (id) {
case kTaskManagerPage:
return IDS_TASK_MANAGER_PAGE_COLUMN;
@@ -326,6 +325,8 @@
gtk_tree_view_set_headers_clickable(GTK_TREE_VIEW(treeview_), TRUE);
gtk_tree_view_set_grid_lines(GTK_TREE_VIEW(treeview_),
GTK_TREE_VIEW_GRID_LINES_HORIZONTAL);
+ g_signal_connect(G_OBJECT(treeview_), "button-press-event",
+ G_CALLBACK(OnButtonPressEvent), this);
g_signal_connect(G_OBJECT(treeview_), "button-release-event",
G_CALLBACK(OnButtonReleaseEvent), this);
gtk_widget_add_events(treeview_,
@@ -468,6 +469,17 @@
menu_controller_->RunMenu();
}
+void TaskManagerGtk::ActivateFocusedTab() {
+ GtkTreeSelection* selection = gtk_tree_view_get_selection(
+ GTK_TREE_VIEW(treeview_));
+
+ // If the user has just double clicked, only one item is selected.
+ GtkTreeModel* model;
+ GList* selected = gtk_tree_selection_get_selected_rows(selection, &model);
+ int row = GetRowNumForPath(reinterpret_cast<GtkTreePath*>(selected->data));
+ task_manager_->ActivateProcess(row);
+}
+
// static
void TaskManagerGtk::OnResponse(GtkDialog* dialog, gint response_id,
TaskManagerGtk* task_manager) {
@@ -501,6 +513,16 @@
}
// static
+gboolean TaskManagerGtk::OnButtonPressEvent(GtkWidget* widget,
+ GdkEventButton* event,
+ TaskManagerGtk* task_manager) {
+ if (event->type == GDK_2BUTTON_PRESS)
+ task_manager->ActivateFocusedTab();
+
+ return FALSE;
+}
+
+// static
gboolean TaskManagerGtk::OnButtonReleaseEvent(GtkWidget* widget,
GdkEventButton* event,
TaskManagerGtk* task_manager) {
« no previous file with comments | « chrome/browser/gtk/task_manager_gtk.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698