tools/gyp/v8.gyp - Issue 155085: Separate native and interpreted regexp by compile time flag, not runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gyp/v8.gyp

Issue 155085: Separate native and interpreted regexp by compile time flag, not runtime. (Closed)

Patch Set: Addressed review comments. Adapted builds scripts. Created 11 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gyp/v8.gyp

diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp

index 8815456d79ff98afe819436fce54a99fb355338b..d6170d22739c7d5a23e601ec14860cb145649a6d 100644

--- a/tools/gyp/v8.gyp

+++ b/tools/gyp/v8.gyp

@@ -419,7 +419,8 @@

'target_name': 'v8_base',

'type': '<(library)',

'defines': [

- 'V8_TARGET_ARCH_IA32'

+ 'V8_TARGET_ARCH_IA32',

+ 'V8_NATIVE_REGEXP'

'include_dirs+': [

'../../src',

@@ -477,7 +478,8 @@

'target_name': 'v8_nosnapshot',

'type': '<(library)',

'defines': [

- 'V8_TARGET_ARCH_IA32'

+ 'V8_TARGET_ARCH_IA32',

+ 'V8_NATIVE_REGEXP'

'dependencies': [

'js2c',

@@ -509,7 +511,8 @@

'target_name': 'v8',

'type': '<(library)',

'defines': [

- 'V8_TARGET_ARCH_IA32'

+ 'V8_TARGET_ARCH_IA32',

+ 'V8_NATIVE_REGEXP'

'dependencies': [

'js2c',

@@ -549,7 +552,8 @@

'target_name': 'v8_shell',

'type': 'executable',

'defines': [

- 'V8_TARGET_ARCH_IA32'

+ 'V8_TARGET_ARCH_IA32',

+ 'V8_NATIVE_REGEXP'

'dependencies': [

'v8',

@@ -579,7 +583,8 @@

'v8',

'defines': [

- 'V8_TARGET_ARCH_IA32'

+ 'V8_TARGET_ARCH_IA32',

+ 'V8_NATIVE_REGEXP'

'include_dirs': [

'../../src',

« no previous file with comments | « test/cctest/test-regexp.cc ('k') | tools/v8.xcodeproj/project.pbxproj » ('j') | no next file with comments »