Issue 155083: X64: Make comparisons work on zero-extended smis.

Issue 155083: X64: Make comparisons work on zero-extended smis. (Closed)

Created:
11 years, 5 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64: Make comparisons work on zero-extended smis. Committed: http://code.google.com/p/v8/source/detail?r=2364

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -26 lines)			Patch
M	src/x64/assembler-x64.h	View		3 chunks	+9 lines, -4 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View		2 chunks	+10 lines, -1 line	0 comments	Download
M	src/x64/codegen-x64.cc	View	1	11 chunks	+19 lines, -21 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/155083/diff/1/4 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/155083/diff/1/4#newcode4396 Line 4396: __ cmpl(answer.reg(), Immediate(0)); Is this different from ...

11 years, 5 months ago (2009-07-06 13:00:17 UTC) #2

William Hesse

http://codereview.chromium.org/155083/diff/1/4 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/155083/diff/1/4#newcode4396 Line 4396: __ cmpl(answer.reg(), Immediate(0)); On 2009/07/06 13:00:17, Lasse Reichstein ...

11 years, 5 months ago (2009-07-06 13:28:08 UTC) #3

Lasse Reichstein

11 years, 5 months ago (2009-07-06 15:00:24 UTC) #4

http://codereview.chromium.org/155083/diff/1/4
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/155083/diff/1/4#newcode5630
Line 5630: __ movq(kScratchRegister, rax);
But we do have setcc. 
IIRC, it sets the low byte of the register to 1 if the condition is true, and to
0 otherwise. Since the register is already zeroed, it should be sufficient.

Expand Messages | Collapse Messages