Issue 155074: DevTools: Provisional support for global properties' and scope roots completi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155074: DevTools: Provisional support for global properties' and scope roots completi... (Closed)

Created:
11 years, 5 months ago by pfeldman

Modified:
9 years, 7 months ago

Reviewers:
yurys

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DevTools: Provisional support for global properties' and scope roots completion in console. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19937

Patch Set 3 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -0 lines)			Patch
	M	webkit/glue/devtools/js/debugger_agent.js	View	1 2	1 chunk	+23 lines, -0 lines	0 comments	Download
	M	webkit/glue/devtools/js/devtools.js	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yurys

http://codereview.chromium.org/155074/diff/1/3 File webkit/glue/devtools/js/debugger_agent.js (right): http://codereview.chromium.org/155074/diff/1/3#newcode1160 Line 1160: if (!expression) { can this block be extracted ...

11 years, 5 months ago (2009-07-06 06:38:20 UTC) #2

pfeldman

11 years, 5 months ago (2009-07-06 07:24:44 UTC) #3

yurys

11 years, 5 months ago (2009-07-06 07:41:34 UTC) #4

On 2009/07/06 07:24:44, pfeldman wrote:
> http://codereview.chromium.org/155074/diff/1/3
> File webkit/glue/devtools/js/debugger_agent.js (right):
> 
> http://codereview.chromium.org/155074/diff/1/3#newcode1160
> Line 1160: if (!expression) {
> On 2009/07/06 06:38:20, Yury Semikhatsky wrote:
> > can this block be extracted into a method? It has nothing to do with the JS
> > evaluation and even its result format differs from that of evaluations.
> Done.

LGTM

Expand Messages | Collapse Messages

Issue 155074: DevTools: Provisional support for global properties' and scope roots completi... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages