Issue 155069: The webkit java applet creation code passes in the baseURL which is typically...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155069: The webkit java applet creation code passes in the baseURL which is typically... (Closed)

Created:
11 years, 5 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

The webkit java applet creation code passes in the baseURL which is typically the url of the containing document to create the plugin widget. This URL should not be treated as the plugin SRC url. This mimics the webkit plugin implementation specifically the upstream WebFrame::createJavaAppletWidget implementation. This fixes http://code.google.com/p/chromium/issues/detail?id=991, which manifested itself due to our plugin implementation issuing a spurious GET request for the baseURL which is incorrect as per above. Bug=991 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20005

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	webkit/glue/webframeloaderclient_impl.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	webkit/glue/webframeloaderclient_impl.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages