Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1200)

Side by Side Diff: chrome/browser/debugger/devtools_manager.cc

Issue 155068: DevTools: preserve focus on activating dev tools window. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/debugger/devtools_manager.h ('k') | chrome/browser/debugger/devtools_window.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/debugger/devtools_manager.h" 5 #include "chrome/browser/debugger/devtools_manager.h"
6 6
7 #include "base/message_loop.h" 7 #include "base/message_loop.h"
8 #include "chrome/browser/browser_process.h" 8 #include "chrome/browser/browser_process.h"
9 #include "chrome/browser/debugger/devtools_window.h" 9 #include "chrome/browser/debugger/devtools_window.h"
10 #include "chrome/browser/debugger/devtools_client_host.h" 10 #include "chrome/browser/debugger/devtools_client_host.h"
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 const IPC::Message& message) { 86 const IPC::Message& message) {
87 DevToolsClientHost* client_host = GetDevToolsClientHostFor(inspected_rvh); 87 DevToolsClientHost* client_host = GetDevToolsClientHostFor(inspected_rvh);
88 if (!client_host) { 88 if (!client_host) {
89 // Client window was closed while there were messages 89 // Client window was closed while there were messages
90 // being sent to it. 90 // being sent to it.
91 return; 91 return;
92 } 92 }
93 client_host->SendMessageToClient(message); 93 client_host->SendMessageToClient(message);
94 } 94 }
95 95
96 void DevToolsManager::ActivateWindow(RenderViewHost* client_rvh) {
97 DevToolsClientHost* client_host = FindOnwerDevToolsClientHost(client_rvh);
98 if (!client_host) {
99 return;
100 }
101 DevToolsWindow* window = client_host->AsDevToolsWindow();
102 DCHECK(window);
103 window->Activate();
104 }
105
96 void DevToolsManager::CloseWindow(RenderViewHost* client_rvh) { 106 void DevToolsManager::CloseWindow(RenderViewHost* client_rvh) {
97 DevToolsClientHost* client_host = FindOnwerDevToolsClientHost(client_rvh); 107 DevToolsClientHost* client_host = FindOnwerDevToolsClientHost(client_rvh);
98 if (!client_host) { 108 if (!client_host) {
99 return; 109 return;
100 } 110 }
101 RenderViewHost* inspected_rvh = GetInspectedRenderViewHost(client_host); 111 RenderViewHost* inspected_rvh = GetInspectedRenderViewHost(client_host);
102 DCHECK(inspected_rvh); 112 DCHECK(inspected_rvh);
103 SendDetachToAgent(inspected_rvh); 113 SendDetachToAgent(inspected_rvh);
104 114
105 UnregisterDevToolsClientHostFor(inspected_rvh); 115 UnregisterDevToolsClientHostFor(inspected_rvh);
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 DevToolsWindow* window = client_host->AsDevToolsWindow(); 278 DevToolsWindow* window = client_host->AsDevToolsWindow();
269 DCHECK(window); 279 DCHECK(window);
270 if (window->is_docked() == docked) { 280 if (window->is_docked() == docked) {
271 return; 281 return;
272 } 282 }
273 283
274 SendDetachToAgent(inspected_rvh); 284 SendDetachToAgent(inspected_rvh);
275 UnregisterDevToolsClientHostFor(inspected_rvh); 285 UnregisterDevToolsClientHostFor(inspected_rvh);
276 OpenDevToolsWindow(inspected_rvh); 286 OpenDevToolsWindow(inspected_rvh);
277 } 287 }
OLDNEW
« no previous file with comments | « chrome/browser/debugger/devtools_manager.h ('k') | chrome/browser/debugger/devtools_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698