Extend the no-match red background to take up more space...

Extend the no-match red background to take up more space
(basically leaving only one pixel margin around the edges).

BUG=htt://crbug.com/15874
TEST=None, Find box should work as before.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19985

[Finnur, 2009-07-03 22:23:34]

Appeasing the pixel gods. :)

[Finnur, 2009-07-03 22:58:40]

After uploading I realized I forgot to test different Windows font size settings
(large/extra large font), which made it clear that we need the height of the
red-background box to be fixed and not depend on the label font size. Updated
the patch.

On 2009/07/03 22:23:34, Finnur wrote:
> Appeasing the pixel gods. :)

[Glen Murphy, 2009-07-06 17:49:30]

LG, with one probably-codesite alert:

http://codereview.chromium.org/155061/diff/4/1003
File chrome/browser/views/find_bar_view.cc (right):

http://codereview.chromium.org/155061/diff/4/1003#newcode452
Line 452: controller->tab_contents()->StartFinding(WideToUTF16(new_contents),
Double-check: this looks messed up (like the line spacing was added through lots
of spacing) in diff view.

[Finnur, 2009-07-06 20:37:33]

http://codereview.chromium.org/155061/diff/4/1003
File chrome/browser/views/find_bar_view.cc (right):

http://codereview.chromium.org/155061/diff/4/1003#newcode452
Line 452: controller->tab_contents()->StartFinding(WideToUTF16(new_contents),
That's Rietveld for you. Because the line used to wrap to the next line,
Rietveld inserts an empty line in the diff so it looks like I added more spaces
than needed.

On 2009/07/06 17:49:30, Glen Murphy wrote:
> Double-check: this looks messed up (like the line spacing was added through
lots
> of spacing) in diff view.