Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 155058: Add back in working layout tests. (Closed)

Created:
11 years, 5 months ago by jorlow
Modified:
9 years, 6 months ago
Reviewers:
dglazkov, ojan
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

Add back in working layout tests. This will close issues 10346 and 14679 TEST=lots BUG=10314, 10343, 10469, 10479, 11322, 11613, 11795, 12053, 15132, 15217, 15270, 15733, 15873, 10346, 14679 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19912

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -32 lines) Patch
M webkit/tools/layout_tests/test_expectations.txt View 1 15 chunks +16 lines, -32 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jorlow
TBR
11 years, 5 months ago (2009-07-03 18:44:25 UTC) #1
ojan
11 years, 5 months ago (2009-07-06 20:59:14 UTC) #2
LGTM

BTW, TEST=lots is basically useless. The point is so QA can know what to test to
verify the fix. In this case, TEST=none would make more sense since you're not
actually changing code.

Powered by Google App Engine
This is Rietveld 408576698